Hide sensitive info from Properties

morganstanley · Jul 27, 2022 · 764a6c0 · 764a6c0
1 parent 338dc9a
commit 764a6c0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/include/kafka/Properties.h b/include/kafka/Properties.h
@@ -79,7 +79,7 @@ class Properties
                           const std::string& key   = kv.first;
                           const std::string& value = kv.second;
 
-                          static const std::regex reSensitiveKey(R"(.+\.password)");
+                          static const std::regex reSensitiveKey(R"(.+\.password|.+\.username)");
                           bool isSensitive = std::regex_match(key, reSensitiveKey);
 
                           ret.append(ret.empty() ? "" : "|").append(key).append("=").append(isSensitive ? "*" : value);

diff --git a/tests/unit/TestProperties.cc b/tests/unit/TestProperties.cc
@@ -90,8 +90,9 @@ TEST(Properties, SensitiveProperties)
     {{
         { "ssl.key.password",      "passwordA" },
         { "ssl.keystore.password", "passwordB" },
+        { "sasl.username",         "userName" },
         { "sasl.password",         "passwordC" },
     }};
 
-    EXPECT_EQ("sasl.password=*|ssl.key.password=*|ssl.keystore.password=*", props.toString());
+    EXPECT_EQ("sasl.password=*|sasl.username=*|ssl.key.password=*|ssl.keystore.password=*", props.toString());
 }