Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy late registered 'connection' listener #35

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

iosifnicolae2
Copy link

This PR fixes a bug when socket.remoteAddress was undefined when registering connection listeners after findhit-proxy constructor was called.
Example:

const server = new.createServer();
server.on('connection', (socket: Socket) => {
   // socket.remoteAddress is not defined here
});

Iosif Nicolae and others added 2 commits March 18, 2022 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant