Fix Ruby 2.3 homebrew issue #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is currently an issue where homebrew will always fail due to an issue with ruby. Forcing homebrew to update before installing any packages fixes this issue.
mattwthompson
added a commit
to mattwthompson/mbuild
that referenced
this pull request
Oct 20, 2017
rvm apparently has some issues that use missing osx functions checking out a later version should fix
ctk3b
reviewed
Oct 31, 2017
.travis.yml
Outdated
| @@ -25,10 +27,10 @@ install: | |||
| - conda config --add channels mosdef | |||
| - conda create -n test-environment python=$PYTHON_VERSION --file requirements.txt | |||
| - source activate test-environment | |||
| - pip install -e . | |||
| - python setup.py install | |||
There was a problem hiding this comment.
This really shouldn't be the issue here. The brew/rvm fixes were all that foyer needed, correct?
.travis.yml
Outdated
|
|
||
| script: | ||
| - py.test -v --cov=mbuild --cov-report= --pyargs mbuild | ||
| - python -m pytest -v --cov=mbuild --cov-report= --pyargs mbuild |
There was a problem hiding this comment.
I thought so, however, our OSX builds are still failing. It is related to pytest. These were ways to attempt to pin down the cause for failure.
A SIGABRT is happening here and although the tests pass on my machine, we cannot figure out what is causing this to fail on Travis.
https://travis-ci.org/mosdef-hub/mbuild/jobs/293851164
Here is a link to one of these instances. Have you encountered this before?
There was a problem hiding this comment.
Brief googling seems to hint at issues specific to python3.5 on travis OSX, perhaps memory related.
This reverts commit 93d3d64.
summeraz
pushed a commit
that referenced
this pull request
Nov 13, 2017
* Add edge buffer in packing functions * Support aspect ratio for generated boxes * Start working with compound_ratio * Support compound_ratio and add test * Cleanup * Actually build n_compounds and test it * Ensure n_compounds contains ints if list * Add docstrings for packing functions * Test for bad combinations of input parameters * Raise an error if compound and n_compounds are of different len * Add optional flag for writing packmol output * Copy packmol PDB directly; don't write from mbuild compound * First attempt at handling packmol errors * Reorder arguments to match previous versions * Force ruby 2.3 for homebrew (#392) * Test packmol error and warning * Small requested fixes * Add _run_packmol helper function and rework tempfile * Add new arguments to some docstrings * Add _check_packmol helper function * Test temp_file behavior in each packing function * Cleanup some docstrings * Cleanup in fill_region: applying edge buffer & docstrings
umesh-timalsina
referenced
this pull request
in GOMC-WSU/MoSDeF-GOMC
Mar 22, 2022
* Add edge buffer in packing functions * Support aspect ratio for generated boxes * Start working with compound_ratio * Support compound_ratio and add test * Cleanup * Actually build n_compounds and test it * Ensure n_compounds contains ints if list * Add docstrings for packing functions * Test for bad combinations of input parameters * Raise an error if compound and n_compounds are of different len * Add optional flag for writing packmol output * Copy packmol PDB directly; don't write from mbuild compound * First attempt at handling packmol errors * Reorder arguments to match previous versions * Force ruby 2.3 for homebrew (#392) * Test packmol error and warning * Small requested fixes * Add _run_packmol helper function and rework tempfile * Add new arguments to some docstrings * Add _check_packmol helper function * Test temp_file behavior in each packing function * Cleanup some docstrings * Cleanup in fill_region: applying edge buffer & docstrings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is currently an issue where homebrew will always fail due to an
issue with ruby. Forcing homebrew to update before installing any
packages fixes this issue.