chore(hyperscript): use HtmlTagNames and SvgTagNames to type hh() fun… (

#109) * chore(hyperscript): use HtmlTagNames and SvgTagNames to type hh() functions Use unused imports in hyperscript helper functions * chore(tests): turn on noUnusedLocals in tsconfig
motorcyclejs · Dec 9, 2016 · dde927b · dde927b
1 parent 2ae7b8b
commit dde927b
Show file tree

Hide file tree

Showing 6 changed files with 13 additions and 12 deletions.
diff --git a/src/virtual-dom/helpers/hyperscript.ts b/src/virtual-dom/helpers/hyperscript.ts
@@ -12,7 +12,7 @@ export interface HyperscriptHelperFn<T extends Node> {
   (children: VNodeChildren): VirtualNode<T>;
 }
 
-export function hh <T extends Node>(tagName: string): HyperscriptHelperFn<T> {
+export function hh <T extends Node>(tagName: HtmlTagNames): HyperscriptHelperFn<T> {
   return function (): VirtualNode<T> {
     const selector = arguments[0];
     const data = arguments[1];

diff --git a/src/virtual-dom/helpers/svg.ts b/src/virtual-dom/helpers/svg.ts
@@ -12,7 +12,7 @@ export interface SvgHyperscriptHelperFn<T extends SVGElement> {
   (children: VNodeChildren): VirtualNode<T>;
 }
 
-function hh <T extends SVGElement>(tagName: string): SvgHyperscriptHelperFn<T> {
+function hh <T extends SVGElement>(tagName: SvgTagNames): SvgHyperscriptHelperFn<T> {
   return function (): VirtualNode<T> {
     const selector = arguments[0];
     const data = arguments[1];

diff --git a/test/driver/integration/events.ts b/test/driver/integration/events.ts
@@ -1,6 +1,6 @@
 import * as assert from 'assert';
 import * as Motorcycle from '@motorcycle/core';
-import { div, h4, h3, h2, span, form, input, makeDomDriver } from '../../../src';
+import { div, h4, h3, h2, input, makeDomDriver } from '../../../src';
 import * as most from 'most';
 import { createRenderTarget } from '../../helpers';
 
@@ -348,7 +348,7 @@ describe('DOMSource.events()', function () {
       el.dispatchEvent(ev);
     }
 
-    const { sources, dispose } = Motorcycle.run<any, any>(app, {
+    const { sources } = Motorcycle.run<any, any>(app, {
       DOM: makeDomDriver(createRenderTarget()),
     });
 
@@ -382,7 +382,7 @@ describe('DOMSource.events()', function () {
       };
     }
 
-    const { sources, dispose } = Motorcycle.run<any, any>(app, {
+    const { sources } = Motorcycle.run<any, any>(app, {
       DOM: makeDomDriver(createRenderTarget()),
     });
 
@@ -416,7 +416,7 @@ describe('DOMSource.events()', function () {
       };
     }
 
-    const { sources, dispose } = Motorcycle.run<any, any>(app, {
+    const { sources } = Motorcycle.run<any, any>(app, {
       DOM: makeDomDriver(createRenderTarget()),
     });
 

diff --git a/test/driver/integration/isolation.ts b/test/driver/integration/isolation.ts
@@ -212,7 +212,7 @@ describe('isolation', function () {
       };
     }
 
-    const { sinks, dispose } = Motorcycle.run<any, any>(app, {
+    const { sinks } = Motorcycle.run<any, any>(app, {
       DOM: makeDomDriver(createRenderTarget()),
     });
 
@@ -304,7 +304,7 @@ describe('isolation', function () {
       };
     }
 
-    const { sinks, dispose } = Motorcycle.run<any, any>(IsolatedApp, {
+    const { sinks } = Motorcycle.run<any, any>(IsolatedApp, {
       DOM: makeDomDriver(createRenderTarget()),
     });
 
@@ -343,7 +343,7 @@ describe('isolation', function () {
       };
     }
 
-    const { sources, dispose } = Motorcycle.run<any, any>(app, {
+    const { sources } = Motorcycle.run<any, any>(app, {
       DOM: makeDomDriver(createRenderTarget()),
     });
 
@@ -389,7 +389,7 @@ describe('isolation', function () {
       };
     }
 
-    const { sources, dispose } = Motorcycle.run<any, any>(app, {
+    const { sources } = Motorcycle.run<any, any>(app, {
       DOM: makeDomDriver(createRenderTarget()),
     });
 
@@ -421,7 +421,7 @@ describe('isolation', function () {
       };
     }
 
-    const { sources, dispose } = Motorcycle.run<any, any>(app, {
+    const { sources } = Motorcycle.run<any, any>(app, {
       DOM: makeDomDriver(createRenderTarget()),
     });
     const isolatedDOMSource = sources.DOM.isolateSource(sources.DOM, 'foo');

diff --git a/test/driver/mockDomSource.ts b/test/driver/mockDomSource.ts
@@ -216,7 +216,7 @@ describe('isolation on MockedDOMSource', function () {
       };
     }
 
-    const {sources, dispose} = run(app, {
+    const {sources} = run(app, {
       DOM: () => mockDomSource({
         '.___ISOLATION': {
           '.bar': {

diff --git a/test/tsconfig.json b/test/tsconfig.json
@@ -12,6 +12,7 @@
     "noImplicitAny": false,
     "sourceMap": true,
     "noUnusedParameters": false,
+    "noUnusedLocals": true,
     "strictNullChecks": true,
     "types": [
       "hyperscript",