[dotnet] Fixing build

mourasman · Sep 28, 2021 · 3b2e16c · 3b2e16c
1 parent 25d1037
commit 3b2e16c
Show file tree

Hide file tree

Showing 6 changed files with 40 additions and 39 deletions.
diff --git a/dotnet/src/webdriver/DevTools/v94/V94Domains.cs b/dotnet/src/webdriver/DevTools/v94/V94Domains.cs
@@ -19,16 +19,16 @@
 using System.Collections.Generic;
 using System.Text;
 
-namespace OpenQA.Selenium.DevTools.v94
+namespace OpenQA.Selenium.DevTools.V94
 {
     /// <summary>
-    /// Class containing the domain implementation for version 90 of the DevTools Protocol.
+    /// Class containing the domain implementation for version 94 of the DevTools Protocol.
     /// </summary>
-    public class v94Domains : DevToolsDomains
+    public class V94Domains : DevToolsDomains
     {
         private DevToolsSessionDomains domains;
 
-        public v94Domains(DevToolsSession session)
+        public V94Domains(DevToolsSession session)
         {
             this.domains = new DevToolsSessionDomains(session);
         }
@@ -46,21 +46,21 @@ public v94Domains(DevToolsSession session)
         /// <summary>
         /// Gets the object used for manipulating network information in the browser.
         /// </summary>
-        public override DevTools.Network Network => new v94Network(domains.Network, domains.Fetch);
+        public override DevTools.Network Network => new V94Network(domains.Network, domains.Fetch);
 
         /// <summary>
         /// Gets the object used for manipulating the browser's JavaScript execution.
         /// </summary>
-        public override JavaScript JavaScript => new v94JavaScript(domains.Runtime, domains.Page);
+        public override JavaScript JavaScript => new V94JavaScript(domains.Runtime, domains.Page);
 
         /// <summary>
         /// Gets the object used for manipulating DevTools Protocol targets.
         /// </summary>
-        public override DevTools.Target Target => new v94Target(domains.Target);
+        public override DevTools.Target Target => new V94Target(domains.Target);
 
         /// <summary>
         /// Gets the object used for manipulating the browser's logs.
         /// </summary>
-        public override DevTools.Log Log => new v94Log(domains.Log);
+        public override DevTools.Log Log => new V94Log(domains.Log);
     }
 }
diff --git a/dotnet/src/webdriver/DevTools/v94/V94JavaScript.cs b/dotnet/src/webdriver/DevTools/v94/V94JavaScript.cs
@@ -18,25 +18,25 @@
 using System;
 using System.Collections.Generic;
 using System.Threading.Tasks;
-using OpenQA.Selenium.DevTools.v94.Page;
-using OpenQA.Selenium.DevTools.v94.Runtime;
+using OpenQA.Selenium.DevTools.V94.Page;
+using OpenQA.Selenium.DevTools.V94.Runtime;
 
-namespace OpenQA.Selenium.DevTools.v94
+namespace OpenQA.Selenium.DevTools.V94
 {
     /// <summary>
     /// Class containing the JavaScript implementation for version 89 of the DevTools Protocol.
     /// </summary>
-    public class v94JavaScript : JavaScript
+    public class V94JavaScript : JavaScript
     {
         private RuntimeAdapter runtime;
         private PageAdapter page;
 
         /// <summary>
-        /// Initializes a new instance of the <see cref="v94JavaScript"/> class.
+        /// Initializes a new instance of the <see cref="V94JavaScript"/> class.
         /// </summary>
         /// <param name="runtime">The DevTools Protocol adapter for the Runtime domain.</param>
         /// <param name="page">The DevTools Protocol adapter for the Page domain.</param>
-        public v94JavaScript(RuntimeAdapter runtime, PageAdapter page)
+        public V94JavaScript(RuntimeAdapter runtime, PageAdapter page)
         {
             this.runtime = runtime;
             this.page = page;

diff --git a/dotnet/src/webdriver/DevTools/v94/V94Log.cs b/dotnet/src/webdriver/DevTools/v94/V94Log.cs
@@ -20,22 +20,22 @@
 using System.Text;
 using System.Threading;
 using System.Threading.Tasks;
-using OpenQA.Selenium.DevTools.v94.Log;
+using OpenQA.Selenium.DevTools.V94.Log;
 
-namespace OpenQA.Selenium.DevTools.v94
+namespace OpenQA.Selenium.DevTools.V94
 {
     /// <summary>
     /// Class containing the browser's log as referenced by version 89 of the DevTools Protocol.
     /// </summary>
-    public class v94Log : DevTools.Log
+    public class V94Log : DevTools.Log
     {
         private LogAdapter adapter;
 
         /// <summary>
-        /// Initializes a new instance of the <see cref="v94Log"/> class.
+        /// Initializes a new instance of the <see cref="V94Log"/> class.
         /// </summary>
         /// <param name="adapter">The adapter for the Log domain.</param>
-        public v94Log(LogAdapter adapter)
+        public V94Log(LogAdapter adapter)
         {
             this.adapter = adapter;
             this.adapter.EntryAdded += OnAdapterEntryAdded;

diff --git a/dotnet/src/webdriver/DevTools/v94/V94Network.cs b/dotnet/src/webdriver/DevTools/v94/V94Network.cs
@@ -20,25 +20,25 @@
 using System.Collections.Generic;
 using System.Text;
 using System.Threading.Tasks;
-using OpenQA.Selenium.DevTools.v94.Fetch;
-using OpenQA.Selenium.DevTools.v94.Network;
+using OpenQA.Selenium.DevTools.V94.Fetch;
+using OpenQA.Selenium.DevTools.V94.Network;
 
-namespace OpenQA.Selenium.DevTools.v94
+namespace OpenQA.Selenium.DevTools.V94
 {
     /// <summary>
     /// Class providing functionality for manipulating network calls using version 89 of the DevTools Protocol
     /// </summary>
-    public class v94Network : DevTools.Network
+    public class V94Network : DevTools.Network
     {
         private FetchAdapter fetch;
         private NetworkAdapter network;
 
         /// <summary>
-        /// Initializes a new instance of the <see cref="v94Network"/> class.
+        /// Initializes a new instance of the <see cref="V94Network"/> class.
         /// </summary>
         /// <param name="network">The adapter for the Network domain.</param>
         /// <param name="fetch">The adapter for the Fetch domain.</param>
-        public v94Network(NetworkAdapter network, FetchAdapter fetch)
+        public V94Network(NetworkAdapter network, FetchAdapter fetch)
         {
             this.network = network;
             this.fetch = fetch;
@@ -80,12 +80,12 @@ public override async Task DisableNetwork()
         /// <returns>A task that represents the asynchronous operation.</returns>
         public override async Task EnableFetchForAllPatterns()
         {
-            await fetch.Enable(new OpenQA.Selenium.DevTools.v94.Fetch.EnableCommandSettings()
+            await fetch.Enable(new OpenQA.Selenium.DevTools.V94.Fetch.EnableCommandSettings()
             {
-                Patterns = new OpenQA.Selenium.DevTools.v94.Fetch.RequestPattern[]
+                Patterns = new OpenQA.Selenium.DevTools.V94.Fetch.RequestPattern[]
                 {
-                    new OpenQA.Selenium.DevTools.v94.Fetch.RequestPattern() { UrlPattern = "*", RequestStage = RequestStage.Request },
-                    new OpenQA.Selenium.DevTools.v94.Fetch.RequestPattern() { UrlPattern = "*", RequestStage = RequestStage.Response }
+                    new OpenQA.Selenium.DevTools.V94.Fetch.RequestPattern() { UrlPattern = "*", RequestStage = RequestStage.Request },
+                    new OpenQA.Selenium.DevTools.V94.Fetch.RequestPattern() { UrlPattern = "*", RequestStage = RequestStage.Response }
                 },
                 HandleAuthRequests = true
             });
@@ -193,9 +193,9 @@ public override async Task ContinueWithAuth(string requestId, string userName, s
             await fetch.ContinueWithAuth(new ContinueWithAuthCommandSettings()
             {
                 RequestId = requestId,
-                AuthChallengeResponse = new v94.Fetch.AuthChallengeResponse()
+                AuthChallengeResponse = new V94.Fetch.AuthChallengeResponse()
                 {
-                    Response = v94.Fetch.AuthChallengeResponseResponseValues.ProvideCredentials,
+                    Response = V94.Fetch.AuthChallengeResponseResponseValues.ProvideCredentials,
                     Username = userName,
                     Password = password
                 }
@@ -212,9 +212,9 @@ public override async Task CancelAuth(string requestId)
             await fetch.ContinueWithAuth(new ContinueWithAuthCommandSettings()
             {
                 RequestId = requestId,
-                AuthChallengeResponse = new OpenQA.Selenium.DevTools.v94.Fetch.AuthChallengeResponse()
+                AuthChallengeResponse = new OpenQA.Selenium.DevTools.V94.Fetch.AuthChallengeResponse()
                 {
-                    Response = v94.Fetch.AuthChallengeResponseResponseValues.CancelAuth
+                    Response = V94.Fetch.AuthChallengeResponseResponseValues.CancelAuth
                 }
             });
         }

diff --git a/dotnet/src/webdriver/DevTools/v94/V94Target.cs b/dotnet/src/webdriver/DevTools/v94/V94Target.cs
@@ -21,22 +21,22 @@
 using System.Collections.ObjectModel;
 using System.Text;
 using System.Threading.Tasks;
-using OpenQA.Selenium.DevTools.v94.Target;
+using OpenQA.Selenium.DevTools.V94.Target;
 
-namespace OpenQA.Selenium.DevTools.v94
+namespace OpenQA.Selenium.DevTools.V94
 {
     /// <summary>
     /// Class providing functionality for manipulating targets for version 89 of the DevTools Protocol
     /// </summary>
-    public class v94Target : DevTools.Target
+    public class V94Target : DevTools.Target
     {
         private TargetAdapter adapter;
 
         /// <summary>
-        /// Initializes a new instance of the <see cref="v94Target"/> class.
+        /// Initializes a new instance of the <see cref="V94Target"/> class.
         /// </summary>
         /// <param name="adapter">The adapter for the Target domain.</param>
-        public v94Target(TargetAdapter adapter)
+        public V94Target(TargetAdapter adapter)
         {
             this.adapter = adapter;
         }

diff --git a/dotnet/src/webdriver/cdp/README.md b/dotnet/src/webdriver/cdp/README.md
@@ -10,7 +10,8 @@ contents of the `//dotnet/src/webdriver/DevTools/v<N-1>` directory into it.
 3. Rename each of the `*.cs` files in `//dotnet/src/webdriver/DevTools/v<N>` so that
 the file names start with `V<N>` instead of `V<N-1>`.
 4. In each of the `*.cs` files in `//dotnet/src/webdriver/DevTools/v<N>`, update all
-occurances of `V<N-1>` to `V<N>`. 
+occurances of `V<N-1>` to `V<N>`. **IMPORTANT:** Do _not_ change the case of `V<N>` in
+each `.cs` file.
 5. In [`//dotnet/src/webdriver/DevTools/DevToolsDomains.cs`](https://github.com/SeleniumHQ/selenium/blob/trunk/dotnet/src/webdriver/DevTools/DevToolsDomains.cs),
 add an entry for version `<N>` to the `SupportedDevToolsVersions` dictionary initialization.
 6. In [`//dotnet/src/webdriver:WebDriver.csproj.prebuild.cmd`](https://github.com/SeleniumHQ/selenium/blob/trunk/dotnet/src/webdriver/WebDriver.csproj.prebuild.cmd),