Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nightly testing job to report "true" coverage #5155

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Vinnl
Copy link
Collaborator

@Vinnl Vinnl commented Oct 9, 2024

People would like to see reports of our coverage without ignore statements; this nightly job produces that.

People would like to see reports of our coverage without ignore
statements; this nightly job produces that.
@Vinnl Vinnl added the Review: XS Code review time: up to 30min label Oct 9, 2024
@Vinnl Vinnl requested review from rhelmer and pdehaan October 9, 2024 15:28
@Vinnl Vinnl self-assigned this Oct 9, 2024
Copy link

github-actions bot commented Oct 9, 2024

Copy link
Collaborator

@rhelmer rhelmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine, @Vinnl did you see @pdehaan's suggestion about using --coverageReporter=babel? If it makes sense to stick to c8 for other reasons that's fine with me just wanted to make sure you saw that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review: XS Code review time: up to 30min
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants