This repository has been archived by the owner on Feb 11, 2020. It is now read-only.
update hapi and fix test #1450
Merged
update hapi and fix test #1450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -17,13 +17,13 @@ module.exports = function(driver, By, done) { | |||
| driver.wait(function() { | |||
| return driver.getCurrentUrl().then(function(url) { | |||
| var result = true; | |||
| if (url.indexOf('http://localhost:3000/en-US/thunderbird/thank-you/') === -1) { | |||
| if (url.indexOf('http://localhost:3000/en-CA/thunderbird/thank-you/') === -1) { | |||
There was a problem hiding this comment.
My best guess is this never really passed. We would just close the test manually and run the next manually thus not sticking around long enough after the test to notice it didn't finish.
Looks like the donation worked though, so the code was good, just a silly test.
|
The checklist for the hapi update:
|
|
@alicoding r? |
|
Don't we have to update other dependencies at all? like |
|
No mention of it in the above upgrade guides, and everything worked. Things I suggest you could do to review this is:
|
|
r+ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.