Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RS publishing tasks for NimbusExperiment #3640

Closed
data-sync-user opened this issue Oct 2, 2020 · 0 comments
Closed

Add RS publishing tasks for NimbusExperiment #3640

data-sync-user opened this issue Oct 2, 2020 · 0 comments
Assignees
@jaredlockhart

Comments

@data-sync-user
Copy link
Collaborator

data-sync-user commented Oct 2, 2020 •
edited
Loading

We need to add RS celery tasks for publishing NimbusExperiments, we can just duplicate the rapid publishing tasks we have now and change to the different model and use the relevant collections.

The existing tasks are here:

https://github.com/mozilla/experimenter/blob/main/app/experimenter/kinto/tasks.py

These tasks are responsible for:

  • Checking for experiments in the review state that are ready to push to RS
  • Checking if there is already an experiment waiting to be reviewed in RS
  • Checking if there is already an experiment that's been rejected in RS, and if so, updating the experiment with the relevant rejection info
  • Pushing an experiment to RS if there's nothing in review
  • Checking if any experiments are live in RS and updating them in the db
  • Checking if an experiment has been manualy marked for completion and remove from collection
  • Checking if any experiments are complete (live in the db but don't appear in RS at all) and updating them in the db

We can use these tasks as written for Nimbus, we just need to change the references from Experiment to NimbusExperiment (and update any specific fields/methods as necessary).  Rather than update the existing ones, we should create a duplicate set that are specifically for the NimbusExperiment, that way we can preserve the functionality of the existing RapidExperiment prototype until the new NimbusExperiment workflow is fully functional.

We'll also need to duplicate the relevant tests.

┆Issue is synchronized with this Jira Task
┆Issue Number: EXP-439
@data-sync-user data-sync-user changed the title Add RS publishing tasks for NimbusExperiment Add RS publishing tasks for NimbusExperiment Oct 2, 2020
jaredlockhart added a commit that referenced this issue Oct 27, 2020
@jaredlockhart
fix #3640 feat(nimbus): add remote settings tasks for nimbus
daac801 
Because

* We need to send and receive nimbus experiments from a specific remote settings collection

This commit

* Adds tasks to push and read nimbus experiments from the nimbus specific collection
  - Push to collection and mark for review with a changelog
  - Read rejected experiments and mark them as draft with a changelog
  - Check for reviewed experiments that have been accepted and mark them live with a changelog
  - Check for removed experiments and mark them completed with a changelog
jaredlockhart added a commit that referenced this issue Oct 27, 2020
@jaredlockhart
fix #3640 feat(nimbus): add remote settings tasks for nimbus
438d97d 
Because

* We need to send and receive nimbus experiments from a specific remote settings collection

This commit

* Adds tasks to push and read nimbus experiments from the nimbus specific collection
  - Push to collection and mark for review with a changelog
  - Read rejected experiments and mark them as draft with a changelog
  - Check for reviewed experiments that have been accepted and mark them live with a changelog
  - Check for removed experiments and mark them completed with a changelog
jaredlockhart added a commit that referenced this issue Oct 27, 2020
@jaredlockhart
fix #3640 feat(nimbus): add remote settings tasks for nimbus
ca21a8a 
Because

* We need to send and receive nimbus experiments from a specific remote settings collection

This commit

* Adds tasks to push and read nimbus experiments from the nimbus specific collection
  - Push to collection and mark for review with a changelog
  - Read rejected experiments and mark them as draft with a changelog
  - Check for reviewed experiments that have been accepted and mark them live with a changelog
  - Check for removed experiments and mark them completed with a changelog
jaredlockhart added a commit that referenced this issue Oct 28, 2020
@jaredlockhart
fix #3640 feat(nimbus): add remote settings tasks for nimbus
af94b5e 
Because

* We need to send and receive nimbus experiments from a specific remote settings collection

This commit

* Adds tasks to push and read nimbus experiments from the nimbus specific collection
  - Push to collection and mark for review with a changelog
  - Read rejected experiments and mark them as draft with a changelog
  - Check for reviewed experiments that have been accepted and mark them live with a changelog
  - Check for removed experiments and mark them completed with a changelog
jaredlockhart added a commit that referenced this issue Oct 28, 2020
@jaredlockhart
fix #3640 feat(nimbus): add remote settings tasks for nimbus
8e2ee16 
Because

* We need to send and receive nimbus experiments from a specific remote settings collection

This commit

* Adds tasks to push and read nimbus experiments from the nimbus specific collection
  - Push to collection and mark for review with a changelog
  - Read rejected experiments and mark them as draft with a changelog
  - Check for reviewed experiments that have been accepted and mark them live with a changelog
  - Check for removed experiments and mark them completed with a changelog
jaredlockhart added a commit that referenced this issue Oct 28, 2020
@jaredlockhart
fix #3640 feat(nimbus): add remote settings tasks for nimbus
b76b72d 
Because

* We need to send and receive nimbus experiments from a specific remote settings collection

This commit

* Adds tasks to push and read nimbus experiments from the nimbus specific collection
  - Push to collection and mark for review with a changelog
  - Read rejected experiments and mark them as draft with a changelog
  - Check for reviewed experiments that have been accepted and mark them live with a changelog
  - Check for removed experiments and mark them completed with a changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jaredlockhart jaredlockhart

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jaredlockhart @data-sync-user