Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cirrus env to start with prefix CIRRUS_ #9501

Closed
data-sync-user opened this issue Sep 26, 2023 · 0 comments · Fixed by #9504
Closed

Update cirrus env to start with prefix CIRRUS_ #9501

data-sync-user opened this issue Sep 26, 2023 · 0 comments · Fixed by #9504

Comments

@data-sync-user
Copy link
Collaborator

Env variables starts with different name and its hard to check value in the implementing application, so we should rename and starts all cirrus env with CIRRUS_ prefix

┆Issue is synchronized with this Jira Task
yashikakhurana added a commit to yashikakhurana/experimenter that referenced this issue Sep 26, 2023
@yashikakhurana
fix mozilla#9501 feat(cirrus): Update variables with prefix CIRRUS_
c51aa47
yashikakhurana added a commit to yashikakhurana/experimenter that referenced this issue Sep 26, 2023
@yashikakhurana
fix mozilla#9501 feat(cirrus): Update some additional .env
fe4142c
@yashikakhurana yashikakhurana mentioned this issue Sep 26, 2023
Merged
yashikakhurana added a commit to yashikakhurana/experimenter that referenced this issue Sep 27, 2023
@yashikakhurana
fix mozilla#9501 feat(cirrus): Update some additional .env
5cbd936
yashikakhurana added a commit to yashikakhurana/experimenter that referenced this issue Sep 27, 2023
@yashikakhurana
fix mozilla#9501 feat(cirrus): Update some additional .env
bf9231f
yashikakhurana added a commit to yashikakhurana/experimenter that referenced this issue Sep 27, 2023
@yashikakhurana
fix mozilla#9501 feat(cirrus): Update some additional .env
419d118
github-merge-queue bot pushed a commit that referenced this issue Sep 27, 2023
@yashikakhurana
fix #9501 feat(cirrus): update variables prefix (#9504)
fe87642 
Because

- ENV variables are being used in cirrus, It is easy to check the set
values if all start with Prefix `CIRRUS_`
- sets the app id and channel from the config for glean initialization

This commit

- Adds a prefix to all .env variables
- Update glean config to use app id and channel correctly

fixes #9501
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix #9501 feat(cirrus): update variables prefix yashikakhurana/experimenter
1 participant
@data-sync-user