Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cirrus): Set glean max event buffer value #10070

Merged
merged 5 commits into from
Jan 22, 2024

Conversation

yashikakhurana
Copy link
Contributor

Because

  • When setting up glean sdk on cirrus side, we set the maxEvents to 500, which means it waits on the client side to gather all 500 events, and once it gets 500 then it sends the batch of events. Implementing applications should be able to adjust the value that works best for them.

This commit

  • Add the option to set no. of events to store in buffer through .env, by default it uses 10 now

Fixes #9534

Copy link
Collaborator

@jaredlockhart jaredlockhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thnx @yashikakhurana !

@yashikakhurana yashikakhurana added this pull request to the merge queue Jan 22, 2024
Merged via the queue into mozilla:main with commit 66624fa Jan 22, 2024
19 checks passed
@yashikakhurana yashikakhurana deleted the 9534/update_max_events branch January 22, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update glean maxEvents value on the cirrus side
4 participants