Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(nimbus): Remove file caching from Dockerfile #11208

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

brennie
Copy link
Member

@brennie brennie commented Aug 20, 2024

Because:

this commit:

  • removes file caching.

Fixes #11207.

Because:

- file caching was added in #5948 (see #5946) to enable remote caching;
- we are no longer using remote caching;
- this step adds complexity to our build process; and
- this step may be triggering unnecessary container rebuilds

this commit:

- removes file caching.

Fixes #11207.
@brennie brennie force-pushed the dev/remove-file-loader branch 5 times, most recently from 3bedac1 to 5b5bc69 Compare August 20, 2024 20:59
Copy link
Collaborator

@jaredlockhart jaredlockhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bye bye file loader 👋 thnx @brennie

@brennie brennie added this pull request to the merge queue Aug 21, 2024
Merged via the queue into main with commit 1347e08 Aug 21, 2024
18 of 19 checks passed
@brennie brennie deleted the dev/remove-file-loader branch August 21, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove file caching from experimenter Dockerfile
2 participants