chore(schemas): update to pydantic v2 #11304
Conversation
| @@ -0,0 +1,134 @@ | |||
| """ | |||
There was a problem hiding this comment.
Eeeeehhhhhh I wish we didn't have to do this. There's not something else that works off the shelf?
There was a problem hiding this comment.
So yea, I agree. I think there may be some options, but nothing that jumped out at me when doing some initial searching. I also know Beth was interested in pursuing something like Zod and I don't really have the time to evaluate things like that at the moment. This is becoming more of an issue for data so I saw this as a bit of a stopgap, but taking inspiration from tooling we already use.
There was a problem hiding this comment.
Okey doke fair enough. Let's do it for now to unblock things and maybe we can find a better solution in the future. Thanks for taking this on @mikewilli 🙏
|
|
||
| # from mozilla_nimbus_schemas import experiments, jetstream | ||
|
|
||
| # __all__ = [f"experiments.{m}" for m in experiments.__all__] + [ | ||
| # f"jetstream.{m}" for m in jetstream.__all__ | ||
| # ] |
There was a problem hiding this comment.
| # from mozilla_nimbus_schemas import experiments, jetstream | |
| # __all__ = [f"experiments.{m}" for m in experiments.__all__] + [ | |
| # f"jetstream.{m}" for m in jetstream.__all__ | |
| # ] |
Can this be removed?
| @@ -0,0 +1,134 @@ | |||
| """ | |||
There was a problem hiding this comment.
Okey doke fair enough. Let's do it for now to unblock things and maybe we can find a better solution in the future. Thanks for taking this on @mikewilli 🙏
Because
This commit
Fixes #11214