DNM/WIP: Manifest v3 Migration (Firefox Preview) #416
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
maxxcrawford
commented
Oct 13, 2022
maxxcrawford
commented
- WIP - Manifest v3 Migration
- Update build command to use Firefox Preview
maxxcrawford
changed the title
|
You also need to update diff --git a/src/manifest.json b/src/manifest.json
index 46f8f99..68c11cd 100644
--- a/src/manifest.json
+++ b/src/manifest.json
@@ -91,12 +91,17 @@
],
"web_accessible_resources": [
- "images/*.svg",
- "icons/*.svg",
- "icons/*.png",
- "fonts/Inter/*.woff2",
- "fonts/Metropolis/*.woff2",
- "*.html"
+ {
+ "resources": [
+ "images/*.svg",
+ "icons/*.svg",
+ "icons/*.png",
+ "fonts/Inter/*.woff2",
+ "fonts/Metropolis/*.woff2",
+ "*.html"
+ ],
+ "matches": ["<all_urls>"]
+ }
]
} |
willdurand
reviewed
Oct 18, 2022
src/manifest.json
Outdated
| "background": { | ||
| "scripts": ["js/libs/browser-polyfill.min.js", "js/background/background.js", "js/background/context-menu.js"] | ||
| "service_worker": "js/background/background.js", |
There was a problem hiding this comment.
service worker isn't enabled on Firefox yet, what you want is an event page
maxxcrawford
force-pushed
the
mv3-spike
branch
from
2973a0d
to
0a77b57
Compare
This was referenced Oct 31, 2022
maxxcrawford
force-pushed
the
mv3-spike
branch
from
f54571b
to
47b79ee
Compare
maxxcrawford
force-pushed
the
mv3-spike
branch
from
1d803cd
to
8944e67
Compare
|
Closing this PR as it has served its purpose. We can revisit the manifest file when ready to migrate. Adding a few review notes for some code changes that I'm not 100% sure why was made (by me). 😎 |
maxxcrawford
commented
Oct 31, 2022
| @@ -7,7 +7,7 @@ browser.storage.local.set({ relayApiSource: `${RELAY_SITE_ORIGIN}/api/v1` }); | |||
| browser.runtime.onInstalled.addListener(async (details) => { | |||
| const { firstRunShown } = await browser.storage.local.get("firstRunShown"); | |||
|
|
|||
| if (details.reason == "update") { | |||
| if (details.reason == "update" || details.reason == "install") { | |||
There was a problem hiding this comment.
question: Why?
Comment on lines
+270
to
+273
| await browser.runtime.sendMessage({ | ||
| method: "storeRuntimeData", | ||
| forceUpdate: true | ||
| }); |
There was a problem hiding this comment.
Question: Why?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.