feat(metrics): add click event for 2fa setup totp code submit #17459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LZoog
approved these changes
Aug 23, 2024
Sounds good. Thank you for the reminder. |
chenba
force-pushed
the
FXA-9575-2fa-submit-glean
branch
from
d3d9fa1
to
22d1ac0
Compare
|
@LZoog the inline setup is quite different so I re-request a review. Thanks! |
LZoog
approved these changes
Aug 23, 2024
| @@ -9,6 +9,8 @@ import { FtlMsg } from 'fxa-react/lib/utils'; | |||
| import { logViewEvent } from '../../lib/metrics'; | |||
| import { REACT_ENTRYPOINT } from '../../constants'; | |||
| import { useFtlMsgResolver } from '../../models'; | |||
| import { GetDataTrioGleanData } from '../GetDataTrio'; | |||
| @@ -2,6 +2,12 @@ | |||
| * License, v. 2.0. If a copy of the MPL was not distributed with this | |||
| * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ | |||
|
|
|||
| export type GleanClickEventDataAttrs = { | |||
chenba
force-pushed
the
FXA-9575-2fa-submit-glean
branch
from
22d1ac0
to
0c46f39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.