Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(oauth-desktop): Call fxaLogin before fxaOAuthLogin with expected data during signin #17744

Merged
merged 1 commit into from
Oct 2, 2024

Commits on Oct 2, 2024

  1. fix(oauth-desktop): Call fxaLogin before fxaOAuthLogin with expected …

    …data during signin
    
    Because:
    * We want to support the new oauth desktop flow, and there is a bug during signin because we were sending fxaOAuthLogin first
    
    This commit:
    * Refactors signin/utils to swap the order these web channel messages fire
    * Fixes an additional intermittent bug for 2FA and new account signins caused by sending keyFetchToken and unwrapBKey
    * Adds oauth desktop config
    * Renames oauthCode to oauthData in oauth hook
    
    fixes FXA-10388
    LZoog committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    8fdea78 View commit details
    Browse the repository at this point in the history