Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can firefoxOptions contain both prefs and profile? #421

Closed
DrMarcII opened this issue Jan 5, 2017 · 2 comments
Closed

Can firefoxOptions contain both prefs and profile? #421

DrMarcII opened this issue Jan 5, 2017 · 2 comments
Labels
selenium

Comments

@DrMarcII
Copy link
Contributor

DrMarcII commented Jan 5, 2017

The Selenium project's implementation of
FirefoxOptions
disallows setting both prefs and profile, but the documentation here makes no reference to this limitation.

Is Selenium protecting against something that is not a problem, or should the documentation here be updated to reflect this limitation?
@jgraham
Copy link
Member

jgraham commented Jan 5, 2017

You can set a custom profile and then write additional prefs into that profile. So Selenium is wrong here.

@jgraham jgraham closed this as completed Jan 5, 2017
@DrMarcII DrMarcII mentioned this issue Jan 5, 2017
Merged
1 task
lukeis pushed a commit to SeleniumHQ/selenium that referenced this issue Jan 8, 2017
@DrMarcII @lukeis
Fixes to FirefoxOptions.java (#3327)
a4e5719 
* Fixes to FirefoxOptions.java

- Remove unneeded check for both prefs and profile being present:
  According to mozilla/geckodriver#421
  having both is valid.
- Add getProfile method:
  Allows for use in intermediate nodes that need to modify the profile
  e.g. to add additional certs or extensions.

* Fix type error.
@lock
Copy link

lock bot commented Aug 17, 2019

This issue has been automatically locked since there has not been any recent activity after it was closed. If you have run into an issue you think is related, please open a new issue.

@lock lock bot locked and limited conversation to collaborators Aug 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
selenium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jgraham @DrMarcII