Bug 1648441 - Implement string list in C# #1108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daoshengmu
force-pushed
the
cSharpStringList
branch
from
538bed3
to
1241047
Compare
Dexterp37
requested changes
Jul 30, 2020
There was a problem hiding this comment.
This looks good overall with the comments below addressed. Please kindly also add documentation for this in this page. Just transform the Kotlin example to C# and you should be done :) See, for example, how it's done for counters
I will be away tomorrow, so please ping @travis79 for any further review on this!
Dexterp37
reviewed
Jul 30, 2020
travis79
reviewed
Jul 30, 2020
There was a problem hiding this comment.
I don't have anything to add to what @Dexterp37 mentioned. There were a handful of comments that needed some corrections.
glean-core/csharp/GleanTests/Metrics/StringListMetricTypeTest.cs
Outdated
Show resolved
Hide resolved
glean-core/csharp/GleanTests/Metrics/StringListMetricTypeTest.cs
Outdated
Show resolved
Hide resolved
glean-core/csharp/GleanTests/Metrics/StringListMetricTypeTest.cs
Outdated
Show resolved
Hide resolved
glean-core/csharp/GleanTests/Metrics/StringListMetricTypeTest.cs
Outdated
Show resolved
Hide resolved
| [Fact] | ||
| public void DisabledListMustNotRecordData() | ||
| { | ||
| // Define a 'stringMetric' string metric, which will be stored in "store1" |
There was a problem hiding this comment.
Suggested change
| // Define a 'stringMetric' string metric, which will be stored in "store1" | |
| // Define a 'stringListMetric' string list metric, which will be stored in "store1" |
glean-core/csharp/GleanTests/Metrics/StringListMetricTypeTest.cs
Outdated
Show resolved
Hide resolved
glean-core/csharp/GleanTests/Metrics/StringListMetricTypeTest.cs
Outdated
Show resolved
Hide resolved
glean-core/csharp/GleanTests/Metrics/StringListMetricTypeTest.cs
Outdated
Show resolved
Hide resolved
glean-core/csharp/GleanTests/Metrics/StringListMetricTypeTest.cs
Outdated
Show resolved
Hide resolved
daoshengmu
force-pushed
the
cSharpStringList
branch
2 times, most recently
from
6bc0ed3
to
dfcdb23
Compare
travis79
approved these changes
Jul 30, 2020
|
The broken Swift formatting is due to an update to the linting tool and may be ignored for now. I'll be working to fix it tomorrow. |
daoshengmu
force-pushed
the
cSharpStringList
branch
from
dfcdb23
to
a53558d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StringListMetricType C# binding.
Tests for StringListMetricType C# binding.