Calculate the database size from all files in the directory #1304
Conversation
glean-core/src/database/mod.rs
Outdated
| /// | ||
| /// # Arguments | ||
| /// | ||
| /// -`path` - The path to the directory |
There was a problem hiding this comment.
| /// -`path` - The path to the directory | |
| /// * `path` - The path to the directory |
glean-core/src/database/mod.rs
Outdated
| if let Ok(entry) = entry { | ||
| let path = entry.path(); | ||
| // the getter is returning the u64 value from NonZeroU64 | ||
| total_size += file_size(&path)?.get(); |
There was a problem hiding this comment.
We can savae some work here. You can read the metadata of an entry directly, that one then has the len. You can then also remove the file_size function as its not used anymore.
If there's no metadata for whatever reason, we shouldn't bail out early here. If we can't read the file size of a single file, we should still read the remaining files.
glean-core/src/database/mod.rs
Outdated
| /// | ||
| /// # Returns | ||
| /// | ||
| /// Returns the non-zero combined size of all files, |
There was a problem hiding this comment.
| /// Returns the non-zero combined size of all files, | |
| /// Returns the non-zero combined size of all files in a directory, |
|
Awesome, makes sense. Thanks for the feedback! Lemme send another PR for you to see if it all looks good. |
You can update this PR (might require force-pushing to your branch) |
|
Hi @badboy, I am not sure why this is happening, but I see that one of the checks is failing. I'd appreciate it if you helped me figure out what the issue is. Thanks. |
That seems unrelated and you can ignore it. |
badboy
changed the title
badboy
changed the title
@badboy, I just fixed the issue. Thanks a lot for the guidance you provided on Bugzilla. Looking forward to some feedback.