Bug 1679949: Don't block on running ping uploading process #1350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We only want to run one ping uploading subprocess at a time -- for one, it might delete ping files, and we can't have contention for that. This is currently handled by waiting on an existing uploading subprocess before firing off a new one. However, this can cause the main dispatcher thread to block, causing work to go uncompleted and subsequent pings to go unsent, on shutdown of the main process. Instead, this just does nothing if an uploading subprocess is already running, since the existing uploader will also pick up any new pings added to the outgoing directory and send them.
badboy
approved these changes
Dec 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only want to run one ping uploading subprocess at a time -- for one, it might
delete ping files, and we can't have contention for that. This is currently
handled by waiting on an existing uploading subprocess before firing off a new
one. However, this can cause the main dispatcher thread to block, causing work
to go uncompleted and subsequent pings to go unsent, on shutdown of the main process.
Instead, this just does nothing if an uploading subprocess is already running,
since the existing uploader will also pick up any new pings added to the
outgoing directory and send them.