Fix 2 lock-order-inversion bugs as found by TSan on m-c tests #1378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a potential deadlock as found by TSan, when running mozilla-central tests (`lock-order-inversion`). Locks should be acquired in the same order across all code paths.
This fixes a potential deadlock as found by TSan, when running mozilla-central tests (`lock-order-inversion`). Locks should be acquired in the same order across all code paths.
badboy
force-pushed
the
tsan-found-an-issue
branch
from
5a4c0c6
to
2881200
Compare
badboy
commented
Dec 10, 2020
| [Full changelog](https://github.com/mozilla/glean/compare/v33.7.0...main) | ||
|
|
||
| * Rust | ||
| * Shut down Glean in tests before resetting to make sure they don't mistakenly init Glean twice in parallel. | ||
| * Introduce the Memory Distribution metric type in the RLB. [#1376](https://github.com/mozilla/glean/pull/1376) |
There was a problem hiding this comment.
I went ahead and fixed the changelog while I was here.
Dexterp37
approved these changes
Dec 10, 2020
|
|
it's green! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Taking this for a try run in m-c to ensure it works before we land this)