Bug 1673672 - User RLB types for core metrics and add more tests #1432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes porting tests from other bindings much more straightforward. Moreover, it paves the way to use glean_parser for generating the internal metrics as well.
This adds more tests ported over from the Kotlin language bindings (GleanTests.kt) to the RLB, specifically the ones testing the behavior around flipping the upload state.
Dexterp37
force-pushed
the
rlb_more_tests
branch
from
52ee730
to
f90468d
Compare
badboy
approved these changes
Jan 15, 2021
| }), | ||
| } | ||
| } | ||
| #[allow(non_upper_case_globals)] |
There was a problem hiding this comment.
You could move this to the top of the file as:
#![allow(non_upper_case_globals)]There was a problem hiding this comment.
Oh right. If it doesn't bother you too much, I'd save another change and do that as a follow-up: we're going to re-generate this file anyway!
| @@ -28,6 +29,11 @@ impl StringMetric { | |||
| pub fn new(meta: glean_core::CommonMetricData) -> Self { | |||
| Self(Arc::new(glean_core::metrics::StringMetric::new(meta))) | |||
| } | |||
|
|
|||
| /// Internal only, synchronous API for setting a string value. | |||
| pub(crate) fn set_sync<S: Into<std::string::String>>(&self, glean: &Glean, value: S) { | |||
There was a problem hiding this comment.
Yey for internal-only APIs and the compiler ensuring it stays that way
| fn flipping_upload_enabled_respects_order_of_events() { | ||
| todo!() | ||
| // NOTES(janerik): |
|
Oh, this will need a rebase because of the changelog changes. You can resolve that on GitHub using the UI if you want. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RLB was using glean-core types instead of the new RLB types, which made writing tests a bit more complicated. This PR uses the binding types for the core metrics (as we do for the other bindings) and then ports back some tests from the Kotling bindings.
Note that using the RLB types also pave the way for using generated metrics :-)