Upgrade rkv to 0.17 #1434
Merged
Upgrade rkv to 0.17 #1434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I looked into the failure on android-build-pr, but couldn't figure out what's going wrong there, as I can't even get the test to work locally without this PR. It's basically just upgrading rkv without any real functionality change, so I don't really expect it to cause any issue. |
yeah, that PR is failing for unrelated reasons. The same test is running on CircleCI and passed there. |
badboy
approved these changes
Jan 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade rkv to 0.17 to remove the dependency to failure in mozilla/rkv#210 as part of effort of removing dependencies to
failurein m-c, asfailurehas been officially deprecated.