Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS: Don't exclude arm64 build for the simulator #1498

Merged
merged 4 commits into from
Feb 24, 2021
Merged

Conversation

badboy
Copy link
Member

@badboy badboy commented Feb 12, 2021

This currently requires a local build of rustc with rust-lang/rust#81966 to enable the target (and also LLVM 12, LLVM 11 untested). Thus we can't really land that before that becomes stable.

I think it would also require direct consumers to switch over to xcframeworks.
It's untested in app-services, I guess it could work for Intel builds there, but this would need to be tested.

No need for a formal review or test yet.

@badboy badboy requested a review from travis79 February 12, 2021 11:18
@travis79
Copy link
Member

I'll be prototyping the "Better Builds" proposal next week, this may help me with packaging the iOS stuff as I'm sure that app-services will face a similar issue with this (as will Nimbus when we have iOS for it).

@badboy badboy added the blocked Blocked pull requests and issues label Feb 16, 2021
@badboy badboy removed the blocked Blocked pull requests and issues label Feb 23, 2021
@badboy badboy marked this pull request as ready for review February 23, 2021 08:52
@auto-assign auto-assign bot requested a review from mdboom February 23, 2021 08:52
@badboy badboy removed the request for review from mdboom February 23, 2021 08:52
@badboy
Copy link
Member Author

badboy commented Feb 23, 2021

aarch64-apple-ios-sim is available now on Nightly ... sort of. One needs to build libstd, but cargo (nightly) can easily do that.
As this only affects developers on M1 machines (like me) we can land this in our build script and I can move my dev environment off a fork of our own code base that already used these changes.

@badboy badboy force-pushed the ios-sim branch 2 times, most recently from 8fd6aa3 to 82aa742 Compare February 23, 2021 14:23
Copy link
Member

@travis79 travis79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: reminder to file a bug to change this once the feature has made it to release in rustc.

@badboy
Copy link
Member Author

badboy commented Feb 24, 2021

Note: reminder to file a bug to change this once the feature has made it to release in rustc.

That might or might not happen anytime soon unfortunately (we'll see, I'm in the rust zulip to see how we can push it forward)

@badboy badboy merged commit a7b9670 into mozilla:main Feb 24, 2021
@badboy badboy deleted the ios-sim branch February 24, 2021 09:52
@badboy
Copy link
Member Author

badboy commented Feb 24, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants