Bug 1706729 - RLB: Dispatch setting the source tag. #1614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dexterp37
approved these changes
May 4, 2021
chutten
requested changes
May 4, 2021
This avoids a race condition where there might not be a global Glean yet. But source tags are only needed for the ping assembly, and that's also dispatched, so either happened before anyway or will happens afterwards.
badboy
force-pushed
the
1706729-checked-set-source-tags
branch
from
9fc3fe3
to
9715e31
Compare
chutten
approved these changes
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids a race condition where there might not be a global Glean
yet.
But source tags are only needed for the ping assembly, and that's also
dispatched, so either happened before anyway or will happens afterwards.