Bug 1722271 - Update to Kotlin 1.5 #1747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7.x is causing some trouble with the rust-gradle plugin right now, so not going there yet.
badboy
force-pushed
the
update-kotlin
branch
2 times, most recently
from
ef40f7a
to
870e640
Compare
The Dokka plugin we were using is outdated and the new one works slightly differently. For now we're simply avoiding that work and remove the API docs for Kotlin.
|
This builds and runs all the Glean kotlin tests, but when I try and build and run the glean-sample-app, it fails in |
This now uses the local server for testing, even though it doesn't send a ping. This is the same fix as mozilla-mobile/android-components 465b85378d32d9f921bab2b7650edcfd3cecc8f7. This also unbreaks the test, applying the fixes done in 3ff81f0 back in February. And last but not least this now builds the sample app including its tests on CI as well, to at least catch those mistakes early.
|
The |
travis79
approved these changes
Aug 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also upgrading Gradle and some dependencies.
Draft as I also want to update some stuff on CI