Bug 1745908 - Python: Copy the environment when launching the upload process #1908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous fix set the `PYTHONPATH` for the subprocess. That overwrites the complete environment, clearing out any other variables. That can cause problems when other parts rely on something, such as the RNG in Python relying on `SYSTEMROOT`
|
@badboy would you kindly add a changelog entry? |
I'll follow this up with a release, I'll do it there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous fix set the
PYTHONPATHfor the subprocess.That overwrites the complete environment, clearing out any other
variables.
That can cause problems when other parts rely on something, such as the
RNG in Python relying on
SYSTEMROOT