Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1781085 - Add back missing client_info metrics #2131

Merged
merged 1 commit into from
Jul 25, 2022
Merged

Bug 1781085 - Add back missing client_info metrics #2131

merged 1 commit into from
Jul 25, 2022

Conversation

badboy
Copy link
Member

@badboy badboy commented Jul 25, 2022

No description provided.

@badboy badboy requested a review from a team as a code owner July 25, 2022 16:00
@badboy badboy requested review from chutten and removed request for a team July 25, 2022 16:00
chutten
chutten requested changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@chutten chutten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs changelog, test.

@badboy badboy force-pushed the set-missing-client-info-parts branch from 08fa2da to b651fbb Compare July 25, 2022 16:22
@badboy
Add back missing client_info metrics
6554909 
Also adding simple tests to check those are passed through the
Kotlin/Swift SDK.
@badboy badboy force-pushed the set-missing-client-info-parts branch from b651fbb to 6554909 Compare July 25, 2022 16:25
@badboy badboy requested review from Dexterp37 and chutten July 25, 2022 16:25
@badboy badboy changed the title Add back missing client_info metrics Bug 1781085 - Add back missing client_info metrics Jul 25, 2022
@badboy badboy enabled auto-merge (rebase) July 25, 2022 16:36
chutten
chutten approved these changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@chutten chutten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@badboy badboy merged commit 465c09c into main Jul 25, 2022
@badboy badboy deleted the set-missing-client-info-parts branch July 25, 2022 16:46
@badboy badboy mentioned this pull request Aug 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chutten chutten chutten approved these changes

@Dexterp37 Dexterp37 Awaiting requested review from Dexterp37

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@badboy @Dexterp37 @chutten