Bug 1780806 - Allow the uploader to signal it is done handling uploads. #2136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chutten
reviewed
Aug 16, 2022
badboy
force-pushed
the
1780806-signal-uploader-shutdown
branch
from
c7f2283
to
9a13b82
Compare
|
Ok, I reworked this a bit now. Additionally I reworked the test. Instead of arbitrary sleep times it now uses a barrier to sync up the 2 threads. That should be much more reliable. |
badboy
force-pushed
the
1780806-signal-uploader-shutdown
branch
2 times, most recently
from
3248c16
to
db59268
Compare
chutten
reviewed
Aug 22, 2022
glean-core/android/src/main/java/mozilla/telemetry/glean/scheduler/PingUploadWorker.kt
Show resolved
Hide resolved
badboy
force-pushed
the
1780806-signal-uploader-shutdown
branch
from
db59268
to
1e77964
Compare
Codecov Report
@@ Coverage Diff @@
## main #2136 +/- ##
=======================================
Coverage 26.47% 26.47%
=======================================
Files 1 1
Lines 34 34
=======================================
Hits 9 9
Misses 25 25 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
badboy
force-pushed
the
1780806-signal-uploader-shutdown
branch
from
1e77964
to
f2ff862
Compare
chutten
approved these changes
Aug 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Putting this up so it's up.
I want to discuss this with chutten when he's back.
I'm not super happy with it because the
UploadResult::Doneneeds to be handled on a different layer than all the otherUploadResultvariants.(It's also only implemented for the RLB right now)