Bug 1791789 - Fix for iOS startup crash caused by Glean #2206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travis79
requested review from
rosahbruno and
badboy
and removed request for
a team and
rosahbruno
This also shuffles some iOS tests around to help reduce the intermittent test failures.
travis79
force-pushed
the
Bug1791789-fix-ios-startup-crash
branch
from
3179e4b
to
278bdbd
Compare
|
The "iOS build and test" task has a single failing test, which is already a known intermittent. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2206 +/- ##
=======================================
Coverage ? 26.47%
=======================================
Files ? 1
Lines ? 34
Branches ? 0
=======================================
Hits ? 9
Misses ? 25
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
rosahbruno
reviewed
Sep 23, 2022
badboy
approved these changes
Sep 30, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tl;dr of the fix: we had recursion wrapped in a loop which I think could have caused two
process()operations to be active at the same time in certain circumstances. This removes the outer while loop and just uses recursion to spawn a newprocess()operation when the previous upload operation completes.Note: This also shuffles some iOS tests around to help reduce the intermittent test failures.