Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1821437 - Upgrade to Xcode 14.0 #2253

Merged
merged 2 commits into from
May 31, 2023
Merged

Bug 1821437 - Upgrade to Xcode 14.0 #2253

merged 2 commits into from
May 31, 2023

Conversation

badboy
Copy link
Member

@badboy badboy commented Nov 1, 2022

This is essentially a revert of the revert-commit f941d76 again.

We can hold off until our consumers are good to go with this.

@badboy badboy requested a review from a team as a code owner November 1, 2022 15:41
@badboy badboy requested review from Dexterp37 and removed request for a team November 1, 2022 15:41
@badboy badboy force-pushed the xcode-14-once-again branch 2 times, most recently from ff74617 to f0bf1cb Compare November 1, 2022 15:57
@codecov
Copy link

codecov bot commented Nov 1, 2022 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (94055a6) 31.70% compared to head (444ee59) 31.70%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2253   +/-   ##
=======================================
  Coverage   31.70%   31.70%           
=======================================
  Files           1        1           
  Lines          41       41           
=======================================
  Hits           13       13           
  Misses         28       28

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Dexterp37
Dexterp37 approved these changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@Dexterp37 Dexterp37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+wc

CHANGELOG.md Outdated Show resolved Hide resolved
@badboy badboy added the blocked Blocked pull requests and issues label Nov 30, 2022
@badboy badboy mentioned this pull request Mar 13, 2023
Closed
@badboy badboy changed the title Upgrade to Xcode 14.0 Bug 1821437 - Upgrade to Xcode 14.0 Apr 3, 2023
@rvandermeulen
Copy link
Contributor

rvandermeulen commented May 27, 2023 •
edited
Loading

@badboy IIUC, Firefox and Focus iOS are both on XCode 14.3 now. Are there other consumers that need to update or can this land now?

@badboy
Upgrade to Xcode 14.3
169347f 
This is essentially a revert of the revert-commit f941d76 again,
adopting it to the latest release.

Installed software: https://circle-macos-docs.s3.amazonaws.com/image-manifest/v12131/manifest.txt
@badboy
Copy link
Member Author

badboy commented May 30, 2023

@badboy IIUC, Firefox and Focus iOS are both on XCode 14.3 now. Are there other consumers that need to update or can this land now?

Nope, that should be it. I just haven't tracked it closely and so missed them upgrading. I'll get this PR updated and landed.

@badboy badboy removed the blocked Blocked pull requests and issues label May 30, 2023
badboy
badboy commented May 30, 2023
View reviewed changes
.circleci/config.yml
@@ -513,14 +513,14 @@ jobs:
- setup-rust-toolchain
- restore_cache:
name: Restore rubygems cache
key: swift-docs-gems-v13
key: swift-docs-gems-v15
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We used -v14 in the reverted commit before. Thus skipping that and going for v15 right away.

@badboy badboy requested a review from travis79 May 30, 2023 10:00
@badboy
Copy link
Member Author

badboy commented May 30, 2023

Waiting for clarification here: mozilla-mobile/focus-ios#3765

@badboy badboy merged commit 11ff4e8 into main May 31, 2023
@badboy badboy deleted the xcode-14-once-again branch May 31, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dexterp37 Dexterp37 Dexterp37 approved these changes

@rosahbruno rosahbruno rosahbruno approved these changes

@travis79 travis79 Awaiting requested review from travis79

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@badboy @rvandermeulen @Dexterp37 @rosahbruno