Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1800620 - Remove glean.validation.first_run_hour #2271

Merged
merged 1 commit into from
Dec 1, 2022
Merged

Bug 1800620 - Remove glean.validation.first_run_hour #2271

merged 1 commit into from
Dec 1, 2022

Conversation

badboy
Copy link
Member

@badboy badboy commented Nov 15, 2022

No description provided.

@badboy
Copy link
Member Author

badboy commented Nov 15, 2022

draft while I re-read the history and figure out if it's ok to remove.

@badboy badboy marked this pull request as ready for review November 18, 2022 11:28
@badboy badboy requested a review from a team as a code owner November 18, 2022 11:28
@badboy badboy requested review from perrymcmanis144 and removed request for a team November 18, 2022 11:28
@badboy
Copy link
Member Author

badboy commented Nov 18, 2022

I couldn't find any analysis done based on this metric as called out in https://bugzilla.mozilla.org/show_bug.cgi?id=1680783

perrymcmanis144
perrymcmanis144 approved these changes Nov 18, 2022
View reviewed changes
Copy link
Contributor

@perrymcmanis144 perrymcmanis144 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matches my expectation for removing first_run_hour, tests pass and no one has objected so LGTM 👍

@badboy badboy added the blocked Blocked pull requests and issues label Nov 21, 2022
@badboy
Copy link
Member Author

badboy commented Nov 21, 2022 •
edited
Loading

blocked while I wait for the feedback period until the end of the week.

@badboy badboy force-pushed the remove-first-run-hour branch 2 times, most recently from 7896373 to b9b1aad Compare December 1, 2022 13:36
@badboy badboy removed the blocked Blocked pull requests and issues label Dec 1, 2022
@badboy badboy merged commit bb2c7af into main Dec 1, 2022
@badboy badboy deleted the remove-first-run-hour branch December 1, 2022 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perrymcmanis144 perrymcmanis144 perrymcmanis144 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@badboy @perrymcmanis144