Take DST into account when converting a calendar into its items #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZONE_OFFSET only provides the default offset from UTC without DST considerations. DST_OFFSET needs to be added to get the full offset for the calendar instance. There's a _very small_ hint in the deprecated `Date` class that one needs to do this[1]. Neither the docs for ZONE_OFFSET[2] nor the ones for DST_OFFSET[3] mention this explicitly. I guess the existence of both fields is the only indicator there. [1]: https://docs.oracle.com/javase/7/docs/api/java/util/Date.html#getTimezoneOffset() [2]: https://docs.oracle.com/javase/7/docs/api/java/util/Calendar.html#ZONE_OFFSET [3]: https://docs.oracle.com/javase/7/docs/api/java/util/Calendar.html#DST_OFFSET
Dexterp37
approved these changes
Oct 8, 2019
Codecov Report
@@ Coverage Diff @@
## master #359 +/- ##
============================================
+ Coverage 75.2% 75.24% +0.03%
- Complexity 307 309 +2
============================================
Files 92 92
Lines 5182 5182
Branches 632 632
============================================
+ Hits 3897 3899 +2
+ Misses 824 822 -2
Partials 461 461
Continue to review full report at Codecov.
|
travis79
approved these changes
Oct 8, 2019
mdboom
approved these changes
Oct 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ZONE_OFFSET only provides the default offset from UTC without DST considerations.
DST_OFFSET needs to be added to get the full offset for the calendar instance.
There's a very small hint in the deprecated
Dateclass that oneneeds to do this1.
Neither the docs for ZONE_OFFSET2 nor the ones for DST_OFFSET3
mention this explicitly.
I guess the existence of both fields is the only indicator there.