Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python: Implement timespan metric type #737

Merged
merged 3 commits into from
Feb 26, 2020
Merged

Python: Implement timespan metric type #737

merged 3 commits into from
Feb 26, 2020

Conversation

mdboom
Copy link
Contributor

@mdboom mdboom commented Feb 25, 2020

No description provided.

@auto-assign auto-assign bot requested a review from Dexterp37 February 25, 2020 23:01
Dexterp37
Dexterp37 approved these changes Feb 26, 2020
View reviewed changes
Copy link
Contributor

@Dexterp37 Dexterp37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ with the comment clarified

glean-core/android/src/test/java/mozilla/telemetry/glean/private/TimespanMetricTypeTest.kt Show resolved Hide resolved
@badboy badboy merged commit c31a992 into mozilla:master Feb 26, 2020
@mdboom mdboom deleted the python-timespan-metric-type branch April 2, 2020 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dexterp37 Dexterp37 Dexterp37 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mdboom @Dexterp37 @badboy