Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐃✁: Remove support for Python 3.5 #987

Merged
merged 3 commits into from
Jun 23, 2020
Merged

🐃✁: Remove support for Python 3.5 #987

merged 3 commits into from
Jun 23, 2020

Conversation

mdboom
Copy link
Contributor

@mdboom mdboom commented Jun 18, 2020

No description provided.

@auto-assign auto-assign bot requested a review from travis79 June 18, 2020 19:03
travis79
travis79 approved these changes Jun 22, 2020
View reviewed changes
Copy link
Member

@travis79 travis79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mdboom mdboom mentioned this pull request Jun 23, 2020
Merged
@mdboom mdboom merged commit 1d747dc into mozilla:main Jun 23, 2020
@mdboom mdboom deleted the python35-removal branch June 23, 2020 19:24
mdboom added a commit to mdboom/glean.rs that referenced this pull request Jun 24, 2020
@mdboom
Python: Don't allow wheels to install on Python 3.5
3490a1a 
This fixes things so the wheel pattern matcher will refuse to install Glean on
Python 3.5

This should have been included in mozilla#987, but I just noticed it now.
@mdboom mdboom mentioned this pull request Jun 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travis79 travis79 travis79 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdboom @travis79