Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Always open in <container>" should respect URL path #976

Closed
mkurz opened this issue Nov 17, 2017 · 16 comments
Closed

"Always open in <container>" should respect URL path #976

mkurz opened this issue Nov 17, 2017 · 16 comments
Labels
Component: Site Assignment Issues related to assigning a site to a container

Comments

@mkurz
Copy link

mkurz commented Nov 17, 2017

I want to sign in to Google Maps with a different account than to google.com:
https://www.google.at/maps/
https://www.google.at/

However as soon as I run "Always open in <container>" for the /maps/ path also the whole domain gets locked into that container. I also tried the lock google.at into a different container afterwards, however that also changes the /maps/ container as well again...

@erjiang
Copy link

erjiang commented Nov 30, 2017

How do you propose users choose between whether they want to create a rule for the entire domain or just for a subdirectory?

@brunoais
Copy link

brunoais commented Nov 30, 2017 via email

@groovecoder
Copy link
Member

See also #473

@groovecoder groovecoder added the Component: Site Assignment Issues related to assigning a site to a container label Dec 5, 2017
@mkurz
Copy link
Author

mkurz commented Dec 5, 2017

@groovecoder What does the assignment label mean?

@groovecoder
Copy link
Member

Just that this issue is related to the site assignment feature.

@jakecoppinger
Copy link

Functioning work around I found after struggling with this:

  • Disable WiFi/network
  • Open tab of the container of your choosing
  • Open maps.google.com, it will error and keep the domain
  • Go Containers menu -> Always Open in <Your Container> (don't worry about the Error page title)
  • Re-enable network

Now https://www.google.com/search?q=test will stay in default container, and maps.google.com will change container, and then redirect to https://www.google.com/maps!

@mkurz
Copy link
Author

mkurz commented Dec 21, 2017

@jakecoppinger Unbelievable, it's working! Thank you very much for sharing this workaround! I am curious, how did you find out?

@jakecoppinger
Copy link

Oh wow, first time I've got a thumbs up to a comment! Glad to have helped!

@mkurz I started playing around with containers this evening and I could see that the Always Open In... mapping of URLs to containers was storing the redirected domain. I tried hitting maps.google.com and stopping the page load as fast as I could so that I could store the different base URL but I couldn't stop it in time. I tried disabling my WiFi to stop the redirect as I couldn't find network throttling in the devtools and the error page title doesn't matter, so it seems that the base URL is the key rather than the page title.

I don't think it would work for differentiating http://example.com/test1 and http://example.com/test2 as these have the same base URL, but it should differentiate http://example.com/test1, http://test1.example.com and http://test2.example.com

@mkurz
Copy link
Author

mkurz commented Dec 21, 2017

@jakecoppinger Thanks!

I just found out we could probably also simply edit the file ~/.mozilla/firefox/<profile-id>/browser-extension-data/@testpilot-containers/storage.js by hand to achieve a desired behaviour. Seems that is the file which stores all the container data.

@groovecoder
Copy link
Member

This is a duplicate of #691

@GJRobert
Copy link

GJRobert commented Dec 11, 2018

@jakecoppinger Thanks!

I just found out we could probably also simply edit the file ~/.mozilla/firefox/<profile-id>/browser-extension-data/@testpilot-containers/storage.js by hand to achieve a desired behaviour. Seems that is the file which stores all the container data.

Editing this file directly works (must quit the browser first), thanks. For example, find the following string in that file like:
siteContainerMap@@_github.com
and append subdirectories or other part of the URL to be like
siteContainerMap@@_github.com/mozilla/multi-account-containers/issues/473
so to always open this issue in a certain container, while keeping other github.com URLs unset.

[Update 2019/1/4]
The method mentioned above is not working any more in Waterfox 56.2.6. Weirdly. Sad.

@StefanSchoof
Copy link

For things like http://example.com/test1 and http://example.com/test2 you can use the Containerise addon to configure this. (found in #473 (comment))

@GJRobert
Copy link

For things like http://example.com/test1 and http://example.com/test2 you can use the Containerise addon to configure this. (found in #473 (comment))

Hi,
I haven't been able to make the mentioned behavior work in my Firefox 68 with Containerise installed. Could you?

@carlos-delamo
Copy link

For things like http://example.com/test1 and http://example.com/test2 you can use the Containerise addon to configure this. (found in #473 (comment))

Hi,
I haven't been able to make the mentioned behavior work in my Firefox 68 with Containerise installed. Could you?

Same issue here. I tried with containerise extension with no luck. Any updates?

@GJRobert
Copy link

For things like http://example.com/test1 and http://example.com/test2 you can use the Containerise addon to configure this. (found in #473 (comment))

Hi,
I haven't been able to make the mentioned behavior work in my Firefox 68 with Containerise installed. Could you?

Same issue here. I tried with containerise extension with no luck. Any updates?

I use https://addons.mozilla.org/en-US/firefox/addon/container-bookmarks/ instead. Bit tricky but works.

@mtalexan
Copy link

For things like http://example.com/test1 and http://example.com/test2 you can use the Containerise addon to configure this. (found in #473 (comment))

Hi,
I haven't been able to make the mentioned behavior work in my Firefox 68 with Containerise installed. Could you?

Same issue here. I tried with containerise extension with no luck. Any updates?

Old response, but the Containerise add-on is working fine for me in the latest version of Firefox (95.0.2).

The big thing to note is that you have to preface glob patters with ! and no whitespace before the pattern, and regex patterns have to be prefaced with @ and you have to carfully backslash escape any literal dots in the (sub)domains.

The GUI isn't the best with Containerise, but I tested it and the glob and literal patterns work for me with domains like play.hbomax.com (matched by pattern !*.hbomax.com) and disneyplus.com (matched by pattern disneyplus.com).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Site Assignment Issues related to assigning a site to a container
Projects
None yet
Development

No branches or pull requests

9 participants