Skip to content

Commit

Permalink
Introduce a L10n-method to translate an element once, and use that …
Browse files Browse the repository at this point in the history
…in `PDFLayerViewer`

Currently we *manually* fetch the "pdfjs-additional-layers" string and update the DOM-element, which was needed since we want to avoid triggering a bunch of otherwise unnecessary translation when appending the entire layer-tree to the DOM.
By introducing a new helper method in the `L10n`-class we can avoid this, and instead use a "data-l10n-id" attribute on the element (as most other viewer code does nowadays).
  • Loading branch information
Snuffleupagus committed Aug 23, 2024
1 parent 908f453 commit fabbe54
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 2 deletions.
9 changes: 9 additions & 0 deletions web/l10n.js
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,15 @@ class L10n {
}
}

/** @inheritdoc */
async translateOnce(element) {
try {
await this.#l10n.translateElements([element]);
} catch (ex) {
console.error(`translateOnce: "${ex}".`);
}
}

/** @inheritdoc */
async destroy() {
for (const element of this.#elements) {
Expand Down
7 changes: 5 additions & 2 deletions web/pdf_layer_viewer.js
Original file line number Diff line number Diff line change
Expand Up @@ -93,13 +93,16 @@ class PDFLayerViewer extends BaseTreeViewer {
/**
* @private
*/
async _setNestedName(element, { name = null }) {
_setNestedName(element, { name = null }) {
if (typeof name === "string") {
element.textContent = this._normalizeTextContent(name);
return;
}
element.textContent = await this._l10n.get("pdfjs-additional-layers");
element.setAttribute("data-l10n-id", "pdfjs-additional-layers");
element.style.fontStyle = "italic";
// Trigger translation manually, since translation is paused when
// the final layer-tree is appended to the DOM.
this._l10n.translateOnce(element);
}

/**
Expand Down

0 comments on commit fabbe54

Please sign in to comment.