-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Range requests are broken when RANGE_CHUNK_SIZE != 64k #5464
Comments
i suspect #5402 being faulty @yurydelendik |
I narrowed it down. for our build we set Once we reverted to 65536 it was working again. |
This report is a little bit confusing:
We don't turn on range requests for small files due to HTTP handling overhead. Please provide more details, e.g. example online and steps to reproduce. |
See Line 113 in 878fad4
|
sorry Yury, I was a bit stressed out because on production no pdfs were showing anymore. This was observed in Chrome, where I can confirm that all chunks were downloaded, but the rendering broke. The file was 600k, so it required multiple range requests to download. After removing our modification of the range chunk size there were more range requests but the document was then rendering fine. |
I am going to close the issue until I have STR |
I need to apologize. it was not caused by pdfjs but changes in our backend when doing decryption for range requests. it was not showing fro smaller ranges but bigger caused problems. sorry for any troubles caused. |
We just noticed that PDF loaded via range requests no longer work in Safari and Chrome
I will investigate and update this ticket. I also so that disableRange is no longer working. Maybe its related to the streaming improvements?
It does work with firefox.
The text was updated successfully, but these errors were encountered: