Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactors PdfDataLister buffering. #5402

Merged
merged 1 commit into from
Oct 13, 2014

Conversation

yurydelendik
Copy link
Contributor

Fixes #5400

@yurydelendik
Copy link
Contributor Author

/botio-linux test

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.21.233.14:8877/35202f87521b028/output.txt

// We own the chunk data, so we can store it as is.
this.buffer = chunk;
} else {
var newBuffer = new Uint8Array(this.buffer.length + chunkLength);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chunk.length instead?
Also, what about caching this.buffer.length to avoid recomputing it below?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chunkLength fixed

this.buffer replaced by buffer

@pdfjsbot
Copy link

From: Bot.io (Linux)


Failed

Full output at http://107.21.233.14:8877/35202f87521b028/output.txt

Total script time: 18.63 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://107.21.233.14:8877/35202f87521b028/reftest-analyzer.html#web=eq.log

@yurydelendik
Copy link
Contributor Author

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_preview from @yurydelendik received. Current queue size: 0

Live output at: http://107.21.233.14:8877/12f2c37bc06eef4/output.txt

brendandahl added a commit that referenced this pull request Oct 13, 2014
Refactors PdfDataLister buffering.
@brendandahl brendandahl merged commit 8445ff1 into mozilla:master Oct 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memory issue when streaming a PDF
5 participants