[api-minor] XFA - Remove the xfaLayer from the DOM when resetting pages (bug 1721977, PR 13427 follow-up)
#13782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snuffleupagus
force-pushed
the
viewer-reset-xfaLayer
branch
from
8c1994e
to
6e4d1f2
Compare
…ages (bug 1721977, PR 13427 follow-up) Originally the `xfaLayer` wasn't implemented in such a way that it supported being removed from the DOM when pages were evicted from the cache, however this limitation was lifted in PR 13427 and the `xfaLayer` should thus be handled similar to e.g. the `annotationLayer`. In addition to removing the `xfaLayer` from the DOM, this patch *also* implements proper rendering/hiding-handling for it (mirroring the `annotationLayer`-code). *Please note:* This patch is tagged API-minor just in case[1], since it changes the signatures of a couple of `PDFPageView`-methods to improve readability of the code. --- [1] Although users are *hopefully* not directly accessing any of the affected methods, and are rather using e.g. `PDFViewer` in which case none of these changes will matter.
Snuffleupagus
force-pushed
the
viewer-reset-xfaLayer
branch
from
6e4d1f2
to
d22ffbb
Compare
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/42f674b85446bb4/output.txt |
…Layer` rendering There's no good reason, as far as I can tell, to have `PDFPageView.reset` attempt to cancel `annotationLayer`/`xfaLayer` rendering in one special-case (this is mostly a leftover from older code). Previously cancelling was moved into the separate `PDFPageView.cancelRendering`-method, and by slightly tweaking the conditions there we're able to remove a bit of now unnecessary code from the `PDFPageView.reset`-method.
Snuffleupagus
force-pushed
the
viewer-reset-xfaLayer
branch
from
6389782
to
f85f579
Compare
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/42f674b85446bb4/output.txt Total script time: 5.23 mins Published |
calixteman
approved these changes
Jul 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally the
xfaLayerwasn't implemented in such a way that it supported being removed from the DOM when pages were evicted from the cache, however this limitation was lifted in PR #13427 and thexfaLayershould thus be handled similar to e.g. theannotationLayer.In addition to removing the
xfaLayerfrom the DOM, this patch also implements proper rendering/hiding-handling for it (mirroring theannotationLayer-code).Please note: This patch is tagged API-minor just in case[1], since it changes the signatures of a couple of
PDFPageView-methods to improve readability of the code.[1] Although users are hopefully not directly accessing any of the affected methods, and are rather using e.g.
PDFViewerin which case none of these changes will matter.