Access navigator safely in the src/display/annotation_layer.js file
#13801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For code that's part of the core library, rather than e.g. the `web/`-folder, we should always be careful about *directly* accessing any DOM methods. The `navigator` is one such structure, which shouldn't be assumed to always be available and we should thus check that it's actually present.[1] Hence this patch re-factors the `navigator.platform` access, in the `AnnotationLayer`-code, to ensure that it's generally safe. Furthermore, to reduce unnecessary repeated string-matching to determine the current platform, we're now using a shadowed getter which is evaluated only once instead (at first access). --- [1] Note e.g. the `isSyncFontLoadingSupported` getter, in the `src/display/font_loader.js` file.
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 1 Live output at: http://54.67.70.0:8877/48f431ea4cc90c5/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 1 Live output at: http://3.101.106.178:8877/5def9d555853829/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/48f431ea4cc90c5/output.txt Total script time: 4.48 mins
|
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/5def9d555853829/output.txt Total script time: 5.41 mins
|
timvandermeij
approved these changes
Jul 27, 2021
|
Thank you for improving this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For code that's part of the core library, rather than e.g. the
web/-folder, we should always be careful about directly accessing any DOM methods.The
navigatoris one such structure, which shouldn't be assumed to always be available and we should thus check that it's actually present.[1]Hence this patch re-factors the
navigator.platformaccess, in theAnnotationLayer-code, to ensure that it's generally safe. Furthermore, to reduce unnecessary repeated string-matching to determine the current platform, we're now using a shadowed getter which is evaluated only once instead (at first access).[1] Note e.g. the
isSyncFontLoadingSupportedgetter, in thesrc/display/font_loader.jsfile.