Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compute correctly the bounding box of a transformed rectangle (fixes #17065) #17067

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Compute correctly the bounding box of a transformed rectangle (fixes #17065) #17067

merged 1 commit into from
Oct 3, 2023

Conversation

calixteman
Copy link
Contributor

No description provided.

@calixteman calixteman linked an issue Oct 3, 2023 that may be closed by this pull request
Pattern: applying a transform breaks the pattern #17065
Closed
@Snuffleupagus
Copy link
Collaborator

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/a1f973c8d2b8fb1/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/045172847fe75ee/output.txt

@Snuffleupagus Snuffleupagus mentioned this pull request Oct 3, 2023
Merged
@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/045172847fe75ee/output.txt

Total script time: 27.74 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 21
  different first/second rendering: 2

Image differences available at: http://54.241.84.105:8877/045172847fe75ee/reftest-analyzer.html#web=eq.log

@calixteman
Copy link
Contributor Author

Interesting, this patch is fixing some issues in issue16127.pdf.
And I don't really see any real visible differences in issue6961.pdf.

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/a1f973c8d2b8fb1/output.txt

Total script time: 37.82 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 22

Image differences available at: http://54.193.163.58:8877/a1f973c8d2b8fb1/reftest-analyzer.html#web=eq.log

Snuffleupagus
Snuffleupagus approved these changes Oct 3, 2023
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice find; please rebase this on master before landing (such that makeref covers the other recently landed PR as well).

r=me, thank you!

@calixteman calixteman merged commit 0e6d0ca into mozilla:master Oct 3, 2023
3 checks passed
@calixteman
Copy link
Contributor Author

/botio makeref

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/25a0c7753218ec6/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/eb429e88d98e817/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/eb429e88d98e817/output.txt

Total script time: 22.27 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/25a0c7753218ec6/output.txt

Total script time: 24.78 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@Snuffleupagus Snuffleupagus mentioned this pull request Jul 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pattern: applying a transform breaks the pattern
3 participants
@calixteman @Snuffleupagus @moz-tools-bot