Ensure that saving, in the viewer, works for partially loaded documents #18254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently saving a modified PDF document may fail *intermittently*, if it's triggered before the entire document has been downloaded. When saving was originally added we only supported forms, and such PDF documents are usually small/simple enough for this issue to be difficult to trigger. However, with editing-support now available as well it's possible to modify much larger documents and this issue thus becomes easier to trigger. One way to reproduce this issue *consistently* is to: - Open http://localhost:8888/web/viewer.html?file=/test/pdfs/pdf.pdf#disableHistory=true&disableStream=true&disableAutoFetch=true - Add an annotation on the first page, it doesn't matter what kind. - Save the document. - Open the resulting document, and notice that with the `master` branch the annotation is missing.
Snuffleupagus
added
viewer
editor
release-blocker
After the previous commit this method has only a single call-site, hence we can inline the needed part of that check directly in `PDFViewerApplication.download` instead.
Snuffleupagus
force-pushed
the
force-save
branch
from
7813d07
to
f4912db
Compare
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/1db7cb735dfc5e1/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/99a6d174a0cfd84/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/1db7cb735dfc5e1/output.txt Total script time: 7.58 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/99a6d174a0cfd84/output.txt Total script time: 17.91 mins
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently saving a modified PDF document may fail intermittently, if it's triggered before the entire document has been downloaded.
When saving was originally added we only supported forms, and such PDF documents are usually small/simple enough for this issue to be difficult to trigger. However, with editing-support now available as well it's possible to modify much larger documents and this issue thus becomes easier to trigger.
One way to reproduce this issue consistently is to:
masterbranch the annotation is missing.