Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce a L10n-method to translate an element once, and use that in PDFLayerViewer #18643

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Introduce a L10n-method to translate an element once, and use that in PDFLayerViewer #18643

merged 1 commit into from
Aug 23, 2024

Commits on Aug 23, 2024

  1. Introduce a L10n-method to translate an element once, and use that … 

    …in `PDFLayerViewer`

Currently we *manually* fetch the "pdfjs-additional-layers" string and update the DOM-element, which was needed since we want to avoid triggering a bunch of otherwise unnecessary translation when appending the entire layer-tree to the DOM.
By introducing a new helper method in the `L10n`-class we can avoid this, and instead use a "data-l10n-id" attribute on the element (as most other viewer code does nowadays).
    @Snuffleupagus
    Snuffleupagus committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    fabbe54 View commit details
    Browse the repository at this point in the history