Store the rotation in the ViewHistory/PDFHistory (issue 5927)
#8868
Conversation
|
/botio unittest |
|
/botio-linux preview |
This changes both `PDFViewer` and `PDFThumbnailViewer` to return early in the `pagesRotation` setters if the rotation doesn't change. It also fixes an existing issue, in `PDFViewer`, that would cause errors if the rotation changes *before* the scale has been set to a non-default value. Finally, in preparation for subsequent patches, it also refactors the rotation code in `web/app.js` to update the thumbnails and trigger rendering with the new `rotationchanging` event.
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/c64fb9405cca849/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/c64fb9405cca849/output.txt Total script time: 2.28 mins Published |
|
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/c0b5351aeadf25b/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @timvandermeij received. Current queue size: 1 Live output at: http://54.215.176.217:8877/968dbe3d1721722/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/c0b5351aeadf25b/output.txt Total script time: 2.56 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/968dbe3d1721722/output.txt Total script time: 12.82 mins
|
|
Nice to have this; thank you! |
Store the rotation in the `ViewHistory`/`PDFHistory` (issue 5927)
Please note that compared to previous attempts at fixing this, the commits in this PR adds rotation support to the history implementation as well.
Fixes #5927.