Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect workerSrc if set #9459

Merged
merged 1 commit into from
Feb 8, 2018
Merged

Conversation

tonyjin
Copy link

@tonyjin tonyjin commented Feb 7, 2018

Respect user-defined workerSrc over internal overrides.

Resolves #9443.

Respect user-defined workerSrc over internal overrides.
@timvandermeij
Copy link
Contributor

This change looks reasonable to me, but since I'm not too familiar with the worker logic, I would like a second pair of eyes here just to be sure I'm not missing anything.

@Snuffleupagus
Copy link
Collaborator

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Feb 8, 2018

From: Bot.io (Linux m4)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/e370d2df7eeb250/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Feb 8, 2018

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.215.176.217:8877/98042e3c69b353b/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Feb 8, 2018

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/98042e3c69b353b/output.txt

Total script time: 23.97 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

pdfjsbot commented Feb 8, 2018

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/e370d2df7eeb250/output.txt

Total script time: 38.90 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current situation, where the workerSrc option is being silently ignored in some cases seems far from ideal to me.

I suppose that the only caveat here would be if there's API consumers that managed to set an invalid workerSrc, and where the current logic thus "saved" them.
However I'm not too worried about that, and besides my impression from questions/issues over the years is that it's a lot more common for users to have trouble because they did not set the workerSrc option at all.

The above is thus a somewhat long-winded way of saying that I think this change is fine. Thanks for the patch!

@Snuffleupagus Snuffleupagus merged commit 2529362 into mozilla:master Feb 8, 2018
@tonyjin
Copy link
Author

tonyjin commented Feb 8, 2018

Thanks! I appreciate the context.

movsb pushed a commit to movsb/pdf.js that referenced this pull request Jul 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants