Update actions in workflows to latest versions #3111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flodolo
commented
Feb 22, 2024
| - uses: actions/checkout@v2 | ||
| - uses: actions/setup-python@v2 | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: 3.9 |
There was a problem hiding this comment.
Is there a reason to keep using 3.9, and not a more recent version (e.g. 3.12)? I noticed black reformats several files locally, but not in the workflow.
There was a problem hiding this comment.
No, we should upgrade. We might even need to upgrade in order to land #3100.
There was a problem hiding this comment.
I'll do it in a separate PR to see if the workflows actually fail as I would expect.
There was a problem hiding this comment.
Makes sense, we should do that also for Docker and Heroku in one go:
https://github.com/mozilla/pontoon/blob/main/docker/Dockerfile
https://github.com/mozilla/pontoon/blob/main/runtime.txt
mathjazz
approved these changes
Feb 22, 2024
ayanaar
pushed a commit
to ayanaar/pontoon
that referenced
this pull request
Feb 23, 2024
ayanaar
pushed a commit
to ayanaar/pontoon
that referenced
this pull request
Feb 23, 2024
mathjazz
added a commit
to mathjazz/pontoon
that referenced
this pull request
Feb 23, 2024
This reverts commit e4b4946.
mathjazz
added a commit
to mathjazz/pontoon
that referenced
this pull request
Feb 23, 2024
This reverts commit e4b4946.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.