-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Django to 4.2.11 #3183
Merged
Merged
Upgrade Django to 4.2.11 #3183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathjazz
force-pushed
the
3059-django-4.2
branch
from
April 22, 2024 23:14
90467c4
to
d73b9a6
Compare
…elationship is used. See: django/django@7ba6ebe
mathjazz
force-pushed
the
3059-django-4.2
branch
from
April 23, 2024 12:36
d73b9a6
to
6cc63b8
Compare
eemeli
approved these changes
Apr 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look reasonable, and if tests pass and it runs fine on staging, it's probably fine.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3059.
The first commit addresses the deprecation warning in Django 3.2.
The next batch of commits updates Django dependencies.
Each Upgrade Django to 4.X.Y commit only updates Django. Commits that follow address issues on build time, on run time and in tests.
The patch is currently deployed to stage for testing. I don't see any issues in the app or sync.
The main (and perhaps only) breaking change for existing deployments is that the ALLOWED_HOSTS variable needs to be explicitly set. It is no longer retrieved from the
SITE_URL
variable.