Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow bitflags 1.2+ #230

Merged
merged 1 commit into from
Nov 15, 2022
Merged

Allow bitflags 1.2+ #230

merged 1 commit into from
Nov 15, 2022

Conversation

badboy
Copy link
Member

@badboy badboy commented Nov 15, 2022

Not sure why this was restricted, but unless we losen this dependency range we cannot get it into m-c.

@saschanaz
Copy link
Collaborator

That was #220 (comment). #225 changed the MSRV so we should be okay now.

Copy link
Collaborator

@saschanaz saschanaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but do we want to bump it to 1.3? Dependabot will nag us very soon anyway.

Edit: Oh wait, we don't have Dependabot set.

@badboy
Copy link
Member Author

badboy commented Nov 15, 2022

Approving, but do we want to bump it to 1.3? Dependabot will nag us very soon anyway.

Edit: Oh wait, we don't have Dependabot set.

It also doesn't matter, because this just means ^1.2 so, everything >= 1.2 and <2

@badboy badboy merged commit 4007996 into main Nov 15, 2022
@badboy badboy deleted the allow-wider-range-of-bitflags branch November 15, 2022 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants