-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support nvc++ and msvc as nvcc host compilers #1889
Support nvc++ and msvc as nvcc host compilers #1889
Conversation
plenty of new tests, nice :) |
I am currently working on adding If needed I can separate the commit that changes those parts of |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1889 +/- ##
==========================================
- Coverage 29.88% 29.77% -0.11%
==========================================
Files 49 49
Lines 17538 17699 +161
Branches 8443 8518 +75
==========================================
+ Hits 5241 5270 +29
- Misses 7214 7311 +97
- Partials 5083 5118 +35
☔ View full report in Codecov by Sentry. |
a3282ef
to
0fb1922
Compare
0fb1922
to
957bfe8
Compare
@sylvestre it seems those CI failures are from infrastructure and not this PR. Can we rerun the failing ones? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for what its worth, looks good to me
@robertmaynard @miscco I guess you are colleagues working on this together, right? Maybe we should discuss (no agenda but to know each others) cheers |
Super happy to talk, sccache is essential for us to be able to run a CI on github PRs for https://github.com/NVIDIA/cccl |
Continues the work of #1884
Extends the nvcc compiler to understand the unique requirements of using
nvc++
orcl.exe
( msvc ) as the host compiler.Due to the fact that
nvc++
pre-processing always has force includes the compiler detection can't presume that the first line of the file will hold the compiler id string. So we instead search for lines starting with a unique starting text.