Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintain order when parsing clang arguments for MSVC #1971

Closed
wants to merge 1 commit into from

Conversation

mathewhodson
Copy link

Fixes #1498
Fixes #1559

@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2023

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (4538675) 31.07% compared to head (38011c3) 30.62%.

Files Patch % Lines
src/compiler/msvc.rs 56.09% 2 Missing and 16 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1971      +/-   ##
==========================================
- Coverage   31.07%   30.62%   -0.45%     
==========================================
  Files          51       51              
  Lines       19191    19198       +7     
  Branches     9232     9238       +6     
==========================================
- Hits         5963     5879      -84     
+ Misses       7754     7750       -4     
- Partials     5474     5569      +95     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@glandium glandium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This actually doesn't fully address #1498, because clang too accepts "--". I have work in progress to fix this once and for all.

@glandium
Copy link
Collaborator

Closing in favor of #1983

@glandium glandium closed this Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with -Xclang and -- compiling using ninja sccache doesn't handle "--"
4 participants